<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103190/">http://git.reviewboard.kde.org/r/103190/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I did not go through the entire patch, but I took a brief look at the new classes. It seems that the ftp method is hardcoded in the SyncManager class. How about having an abstract manager from which a FtpSyncManager, WebDavSyncManager, FirefoxSyncManager can derive. What do you think?
I think it would be easier to write the other managers if we derive it from the abstract class.</pre>
<br />
<p>- Tirtha</p>
<br />
<p>On November 20th, 2011, 11:28 a.m., Andrea Diamantini wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for rekonq.</div>
<div>By Andrea Diamantini.</div>
<p style="color: grey;"><i>Updated Nov. 20, 2011, 11:28 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch adds the sync feature for rekonq bookmarks, history and passwords. It works (actually) just with remote ftp sites and should be the first stone for other remote sync solutions (webdav? ownCloud? firefox Sync? etc...)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/CMakeLists.txt <span style="color: grey">(ced397c)</span></li>
<li>src/application.h <span style="color: grey">(acc0335)</span></li>
<li>src/application.cpp <span style="color: grey">(fcabc20)</span></li>
<li>src/bookmarks/bookmarkmanager.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/bookmarks/bookmarkmanager.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/bookmarks/bookmarkowner.cpp <span style="color: grey">(40b070d)</span></li>
<li>src/bookmarks/bookmarkprovider.h <span style="color: grey">(fe49eae)</span></li>
<li>src/bookmarks/bookmarkprovider.cpp <span style="color: grey">(9b4be96)</span></li>
<li>src/bookmarks/bookmarkscontextmenu.cpp <span style="color: grey">(735e341)</span></li>
<li>src/bookmarks/bookmarkspanel.cpp <span style="color: grey">(eb46119)</span></li>
<li>src/bookmarks/bookmarkstoolbar.cpp <span style="color: grey">(23af65c)</span></li>
<li>src/bookmarks/bookmarkstreemodel.cpp <span style="color: grey">(42cd7b2)</span></li>
<li>src/history/historymanager.h <span style="color: grey">(bdce16d)</span></li>
<li>src/history/historymanager.cpp <span style="color: grey">(a5cd29e)</span></li>
<li>src/mainwindow.cpp <span style="color: grey">(811f1cf)</span></li>
<li>src/newtabpage.cpp <span style="color: grey">(f797e49)</span></li>
<li>src/rekonq.kcfg <span style="color: grey">(227c6b1)</span></li>
<li>src/rekonqui.rc <span style="color: grey">(bad5661)</span></li>
<li>src/sync/settings_sync.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/sync/syncmanager.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/sync/syncmanager.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/sync/syncwidget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/sync/syncwidget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/urlbar/bookmarkwidget.cpp <span style="color: grey">(5beecb4)</span></li>
<li>src/urlbar/favoritewidget.cpp <span style="color: grey">(da94410)</span></li>
<li>src/urlbar/urlbar.cpp <span style="color: grey">(9460cf8)</span></li>
<li>src/urlbar/urlresolver.cpp <span style="color: grey">(e7f41c7)</span></li>
<li>src/webtab.cpp <span style="color: grey">(61c9077)</span></li>
<li>src/webview.cpp <span style="color: grey">(bd159bd)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103190/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>