[rekonq] Re: Review Request: SSL dialogs improvements

[Richard J. Moore]

> On July 21, 2011, 11:43 a.m., Richard J. Moore wrote:
> > src/sslinfodialog.cpp, line 81
> > <http://git.reviewboard.kde.org/r/101925/diff/1/?file=26748#file26748line81>
> >
> >     Errors may contain < or & characters. You need something like:
> >     
> >     s = s.replace(QL1S("&"), QL1S("&amp;"));
> >     s = s.replace(QL1S("<"), QL1S("&lt;"));

This escaping can be better implemented by using Qt::escape.

http://doc.qt.nokia.com/4.7/qt.html#escape


- Richard J.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101925/#review4928
-----------------------------------------------------------


On July 11, 2011, 10:21 p.m., Andrea Diamantini wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101925/
> -----------------------------------------------------------
> 
> (Updated July 11, 2011, 10:21 p.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> The patch, available on the remote repo in the branch called "SSL_Dialogs_Improvements",  provides 2 new GUIs, similar to the ones provided by Google Chrome, to notify users about SSL infos.
> The patch allows also to export the certificate in binary form. Further upgrades in the SSL management have to be done in kdelibs.
> 
> "Side" change to render the same informations Chrom* does is about history: upgraded HISTORY_VERSION and added a firstDateTimeVisit entry in the HistoryTime struct.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt f623adf 
>   src/history/historymanager.h 8650bd1 
>   src/history/historymanager.cpp 8113add 
>   src/history/historymodels.h 8cb1a5d 
>   src/history/historymodels.cpp 2cab8ef 
>   src/sslinfo.ui PRE-CREATION 
>   src/sslinfodialog.h PRE-CREATION 
>   src/sslinfodialog.cpp PRE-CREATION 
>   src/sslinfodialog_p.h 72f1679 
>   src/urlbar/sslwidget.h PRE-CREATION 
>   src/urlbar/sslwidget.cpp PRE-CREATION 
>   src/urlbar/urlbar.cpp 078dc6a 
>   src/webpage.h 09977bf 
>   src/webpage.cpp 9499d6f 
> 
> Diff: http://git.reviewboard.kde.org/r/101925/diff
> 
> 
> Testing
> -------
> 
> Tested against the following sites:
> - https://localhost, with an untrusted and expired certificate
> - https://encrypted.google.com
> - https://paypal.com
> - https://sites.nea.org/JoinNea/
> 
> In all these sites, rekonq behaves similar to what Chrom* does.
> 
> 
> Screenshots
> -----------
> 
> SSL Widget
>   http://git.reviewboard.kde.org/r/101925/s/196/
> SSL info Dialog
>   http://git.reviewboard.kde.org/r/101925/s/197/
> 
> 
> Thanks,
> 
> Andrea
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110721/0f361577/attachment-0001.htm