[rekonq] Re: Review Request: SSL dialogs improvements

[Pino Toscano]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101925/#review4930
-----------------------------------------------------------



src/sslinfo.ui
<http://git.reviewboard.kde.org/r/101925/#comment4296>

    Please run `fixuifiles` (part of kdesdk/scripts) on the ui files, before their final push.



src/urlbar/sslwidget.cpp
<http://git.reviewboard.kde.org/r/101925/#comment4300>

    Why the <h4> tag?
    If you want to make the text bold, pick the font of the label, set it bold and set it back.



src/urlbar/sslwidget.cpp
<http://git.reviewboard.kde.org/r/101925/#comment4301>

    missing i18n()?



src/urlbar/sslwidget.cpp
<http://git.reviewboard.kde.org/r/101925/#comment4302>

    "It's" -> "It is".
    Please no contractions in i18n strings.



src/webpage.h
<http://git.reviewboard.kde.org/r/101925/#comment4298>

    make it const



src/webpage.cpp
<http://git.reviewboard.kde.org/r/101925/#comment4299>

    Just exit at the first invalid certificate:
      for (cert, ...) { if (!cert.isValid()) return false; }
      return true;


- Pino


On July 11, 2011, 10:21 p.m., Andrea Diamantini wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101925/
> -----------------------------------------------------------
> 
> (Updated July 11, 2011, 10:21 p.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> The patch, available on the remote repo in the branch called "SSL_Dialogs_Improvements",  provides 2 new GUIs, similar to the ones provided by Google Chrome, to notify users about SSL infos.
> The patch allows also to export the certificate in binary form. Further upgrades in the SSL management have to be done in kdelibs.
> 
> "Side" change to render the same informations Chrom* does is about history: upgraded HISTORY_VERSION and added a firstDateTimeVisit entry in the HistoryTime struct.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt f623adf 
>   src/history/historymanager.h 8650bd1 
>   src/history/historymanager.cpp 8113add 
>   src/history/historymodels.h 8cb1a5d 
>   src/history/historymodels.cpp 2cab8ef 
>   src/sslinfo.ui PRE-CREATION 
>   src/sslinfodialog.h PRE-CREATION 
>   src/sslinfodialog.cpp PRE-CREATION 
>   src/sslinfodialog_p.h 72f1679 
>   src/urlbar/sslwidget.h PRE-CREATION 
>   src/urlbar/sslwidget.cpp PRE-CREATION 
>   src/urlbar/urlbar.cpp 078dc6a 
>   src/webpage.h 09977bf 
>   src/webpage.cpp 9499d6f 
> 
> Diff: http://git.reviewboard.kde.org/r/101925/diff
> 
> 
> Testing
> -------
> 
> Tested against the following sites:
> - https://localhost, with an untrusted and expired certificate
> - https://encrypted.google.com
> - https://paypal.com
> - https://sites.nea.org/JoinNea/
> 
> In all these sites, rekonq behaves similar to what Chrom* does.
> 
> 
> Screenshots
> -----------
> 
> SSL Widget
>   http://git.reviewboard.kde.org/r/101925/s/196/
> SSL info Dialog
>   http://git.reviewboard.kde.org/r/101925/s/197/
> 
> 
> Thanks,
> 
> Andrea
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110721/495ff10b/attachment-0001.htm