[rekonq] Re: Review Request: This is JuniorJob about doing better Tab Previews

[Vyacheslav Blinov]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101848/
-----------------------------------------------------------

(Updated July 13, 2011, 11:11 a.m.)


Review request for rekonq.


Changes
-------

At first I had no public setWebTab and WebTab was specified with constructor, but my mentor Tirtha Chatterjee had an opinion that this is not so clear, so I changed this.

Here I'm setted setWebTab to be private again, now WebTab is specified using constructor: TabPreviewPopup(WebTab *tab, QWidget *parent = 0);


Summary
-------

Improvements:

* title of the page is removed since it is visible on a tab.
* widget now has a smooth 3d look'n'feel with Oxygen thanks to raisen frame
* widget has rouned corners in all the styles
* url of the page is elided
* with compositing tab previews will be shown semitransparent with 25% alpha by default, witch can be setted to be optional later
* code of tab preview is now separated from tab bar so it is more explicit


Diffs (updated)
-----

  src/CMakeLists.txt db9506a 
  src/tabbar.h c1b0ba5 
  src/tabbar.cpp dee49ea 
  src/tabpreviewpopup.h PRE-CREATION 
  src/tabpreviewpopup.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/101848/diff


Testing
-------

Tested with different styles: it still looks ok, without compositing transparency didn't works


Screenshots
-----------

sample of tab preview
  http://git.reviewboard.kde.org/r/101848/s/193/


Thanks,

Vyacheslav

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110713/a7345ad6/attachment.htm