[rekonq] Re: Review Request: This is JuniorJob about doing better Tab Previews

[Andrea Diamantini]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101848/#review4670
-----------------------------------------------------------


A new read to your code and I found another "small" thing to fix, IMHO.
First, the ctor indicated is quite strange: in fact you should usually declare the QWidget parent as last (and unique) optional argument. And then let it to be explicit. Something like this:

explicit TabPreviewPopup(WebTab *tab, QWidget *parent = 0);

In fact, why do you let people "set" their webtab? You use it just once and just in a particular case. I really think a reduced and safer API would be better here.

- Andrea


On July 13, 2011, 9:15 a.m., Vyacheslav Blinov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101848/
> -----------------------------------------------------------
> 
> (Updated July 13, 2011, 9:15 a.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> Improvements:
> 
> * title of the page is removed since it is visible on a tab.
> * widget now has a smooth 3d look'n'feel with Oxygen thanks to raisen frame
> * widget has rouned corners in all the styles
> * url of the page is elided
> * with compositing tab previews will be shown semitransparent with 25% alpha by default, witch can be setted to be optional later
> * code of tab preview is now separated from tab bar so it is more explicit
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt db9506a 
>   src/tabbar.h c1b0ba5 
>   src/tabbar.cpp dee49ea 
>   src/tabpreviewpopup.h PRE-CREATION 
>   src/tabpreviewpopup.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/101848/diff
> 
> 
> Testing
> -------
> 
> Tested with different styles: it still looks ok, without compositing transparency didn't works
> 
> 
> Screenshots
> -----------
> 
> sample of tab preview
>   http://git.reviewboard.kde.org/r/101848/s/193/
> 
> 
> Thanks,
> 
> Vyacheslav
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110713/947e4ee3/attachment.htm