[rekonq] Re: Review Request: GCI Task: Use Alt+Enter in Url bar to open the link in new focused tab
Andrea Diamantini
adjam7 at gmail.com
Wed Jan 26 19:38:36 CET 2011
> On Jan. 7, 2011, 2:42 p.m., Andrea Diamantini wrote:
> > This (nice) feature needs complete rewrite. MainWindow class has not to be touched, and a check for the CTRL button pressed should be added in the CompletionWidget class, where the "chosenUrl" signal will be emitted.
>
> Furkan Üzümcü wrote:
> Actually this isn't necessary imho. If I would want to open a link in new tab I would open a new tab then open it. Let's not make Rekonq a features garbage.
> Do you agree with me?
it was your request :)
If you no more wanna suggest it, just close it.
- Andrea
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100210/#review757
-----------------------------------------------------------
On Dec. 31, 2010, 2:23 p.m., Furkan Üzümcü wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100210/
> -----------------------------------------------------------
>
> (Updated Dec. 31, 2010, 2:23 p.m.)
>
>
> Review request for rekonq.
>
>
> Summary
> -------
>
> * Use Alt+Enter in Url bar to open the link in new focused tab
>
>
> Diffs
> -----
>
> src/mainwindow.h 33fd202
> src/mainwindow.cpp 447885d
>
> Diff: http://git.reviewboard.kde.org/r/100210/diff
>
>
> Testing
> -------
>
> Tested and works!
>
>
> Thanks,
>
> Furkan
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110126/d3d30fed/attachment-0001.htm
More information about the rekonq
mailing list