[rekonq] Re: Review Request: GCI Taks: Add a combobox with different settings to the “When Hovering Tab Feature”

[Andrea Diamantini]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100282/#review758
-----------------------------------------------------------



src/application.cpp
<http://git.reviewboard.kde.org/r/100282/#comment576>

    This code (from 530 to 550) should be a switch IMHO:
    switch(ReKonfig::hoveringTabOption())
    {
    case 1:
    ..
    ..
    };
    


- Andrea


On 2010-12-31 17:44:18, Furkan Üzümcü wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100282/
> -----------------------------------------------------------
> 
> (Updated 2010-12-31 17:44:18)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> Add a combobox with different settings to the “When Hovering Tab Feature”
> * Show Preview
> * Show Title Tooltip
> * Show URL Tooltip
> * Show Nothing
> 
> https://bugs.kde.org/show_bug.cgi?id=260343
> 
> 
> Diffs
> -----
> 
>   src/tabbar.cpp 286d7d4 
>   src/settings/tabswidget.cpp aa55533 
>   src/tabbar.h acd8e2f 
>   src/application.cpp 41c6e76 
>   src/mainview.cpp 850101e 
>   src/rekonq.kcfg b605e69 
>   src/settings/settings_tabs.ui 2e2ee10 
> 
> Diff: http://git.reviewboard.kde.org/r/100282/diff
> 
> 
> Testing
> -------
> 
> *Tested and works!
> 
> 
> Thanks,
> 
> Furkan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110107/4f2352a1/attachment.htm