[rekonq] Re: Review Request: GCI Task: Add an option to show the Favicon of the current site as window icon

[Furkan Üzümcü]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100312/
-----------------------------------------------------------

(Updated Jan. 25, 2011, 7:15 a.m.)


Review request for rekonq.


Changes
-------

I finally had a chance to update this patch. I hope it's going to make it to the alpha release.
The only problem with it is it doesn't change the window icon when you press the new tab button on the tab bar.


Summary
-------

Added an option, so that people who would like to have the Favicon of the current website as the icon of rekonq’s window, can enable it.


Diffs (updated)
-----

  src/application.cpp f38832c 
  src/mainview.cpp 699103a 
  src/mainwindow.h c915934 
  src/mainwindow.cpp ece11cc 
  src/rekonq.kcfg d7d496f 
  src/settings/settings_appearance.ui f7dd474 
  src/tabbar.cpp 7a8419a 
  src/webview.h a06a2cb 
  src/webview.cpp d3eb2f4 

Diff: http://git.reviewboard.kde.org/r/100312/diff


Testing
-------

* Tested and works!


Thanks,

Furkan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110125/b7c97254/attachment.htm