[rekonq] Re: Review Request: GCI Task: Add an option to show the Favicon of the current site as window icon

[Andrea Diamantini]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100312/#review931
-----------------------------------------------------------



src/mainview.cpp
<http://git.reviewboard.kde.org/r/100312/#comment778>

    Again, as in #318 & #320, I don't understand the need for this.



src/mainview.cpp
<http://git.reviewboard.kde.org/r/100312/#comment779>

    I'm not sure this works. What if policy is "open tab near selected"?



src/mainwindow.cpp
<http://git.reviewboard.kde.org/r/100312/#comment777>

    I don't understand the need for #318 & #320



src/mainwindow.cpp
<http://git.reviewboard.kde.org/r/100312/#comment776>

    Why that, having a m_view instance?


- Andrea


On Jan. 7, 2011, 1:18 p.m., Furkan Üzümcü wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100312/
> -----------------------------------------------------------
> 
> (Updated Jan. 7, 2011, 1:18 p.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> Added an option, so that people who would like to have the Favicon of the current website as the icon of rekonq’s window, can enable it.
> 
> 
> Diffs
> -----
> 
>   src/application.cpp 41c6e76 
>   src/mainview.h bc8b676 
>   src/mainview.cpp 94dc168 
>   src/mainwindow.h 7dfc186 
>   src/mainwindow.cpp 11c00c2 
>   src/rekonq.kcfg 6700b4e 
>   src/settings/settings_appearance.ui f7dd474 
>   src/tabbar.cpp 286d7d4 
>   src/webview.h a06a2cb 
>   src/webview.cpp 0c06a4f 
> 
> Diff: http://git.reviewboard.kde.org/r/100312/diff
> 
> 
> Testing
> -------
> 
> * Tested and works!
> 
> 
> Thanks,
> 
> Furkan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110116/2ea45c11/attachment-0001.htm