[rekonq] Re: Review Request: GCI Task: Translate page to KDE's default language

[Rohan Garg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100323/#review982
-----------------------------------------------------------


Im a bit against this patch mainly because we do not use the Google Translate API for this, and also do not give the user a choice to switch between service providers. At most, id call this a workaround for a bigger issue i.e translating web pages into local languages.

- Rohan


On Jan. 8, 2011, 8:53 p.m., Furkan Üzümcü wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100323/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2011, 8:53 p.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> Added context menu to translate page to KDE's default language.
> 
> 
> Diffs
> -----
> 
>   src/webview.h a06a2cb 
>   src/webview.cpp 49fa103 
> 
> Diff: http://git.reviewboard.kde.org/r/100323/diff
> 
> 
> Testing
> -------
> 
> * Tested and works.
> 
> 
> Thanks,
> 
> Furkan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110118/662a8b38/attachment-0001.htm