[rekonq] Re: Review Request: GCI Task: Translate page to KDE's default language

[Felix Rohrbach]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100323/#review981
-----------------------------------------------------------



src/webview.cpp
<http://git.reviewboard.kde.org/r/100323/#comment799>

    You don't need that change in this patch, as it's far away from everything else you changed. Atm it also breaks the patch, so remove this or rebase the patch.


Could you make sure that the menu entry is not shown when you are on one of rekonq's own pages? Also, it would be nice if could disable this feature when you are on a site in your system language (google gives an error page on such tries).

- Felix


On Jan. 8, 2011, 8:53 p.m., Furkan Üzümcü wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100323/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2011, 8:53 p.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> Added context menu to translate page to KDE's default language.
> 
> 
> Diffs
> -----
> 
>   src/webview.h a06a2cb 
>   src/webview.cpp 49fa103 
> 
> Diff: http://git.reviewboard.kde.org/r/100323/diff
> 
> 
> Testing
> -------
> 
> * Tested and works.
> 
> 
> Thanks,
> 
> Furkan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110118/2293042d/attachment.htm