[rekonq] Re: Review Request: GCI Taks: Added support for pinning tabs

[Andrea Diamantini]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100305/#review936
-----------------------------------------------------------


uhm... I have a lot of doubts here. 
First, this patch changes rekonq behavior and this HAS to be fixed. In fact, leaving on a pinned tab, it is reloaded on startup. And this is not good. At least you can remember settings and reload them when the "restore last opened tabs" is set.
Second, I'm not sure changing tabbar dimension is enough to have a "pinned" tab. You should probably also set it to have just the icon.

ok, let's go with these, for now. Meeting time now.. :) 


- Andrea


On Jan. 14, 2011, 2:21 p.m., Furkan Üzümcü wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100305/
> -----------------------------------------------------------
> 
> (Updated Jan. 14, 2011, 2:21 p.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> Added support for pinning tabs like Firefox 4 and Google Chrome.
> The default preview size was discussed on IRC.
> 
> 
> Diffs
> -----
> 
>   src/application.cpp 466a0a4 
>   src/mainview.h bc8b676 
>   src/mainview.cpp cbe862f 
>   src/rekonq.kcfg cda76d8 
>   src/tabbar.h 4170786 
>   src/tabbar.cpp fcc7b78 
> 
> Diff: http://git.reviewboard.kde.org/r/100305/diff
> 
> 
> Testing
> -------
> 
> * Tested and works.
> 
> 
> Thanks,
> 
> Furkan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110116/e826a669/attachment.htm