<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100305/">http://git.reviewboard.kde.org/r/100305/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">uhm... I have a lot of doubts here.
First, this patch changes rekonq behavior and this HAS to be fixed. In fact, leaving on a pinned tab, it is reloaded on startup. And this is not good. At least you can remember settings and reload them when the "restore last opened tabs" is set.
Second, I'm not sure changing tabbar dimension is enough to have a "pinned" tab. You should probably also set it to have just the icon.
ok, let's go with these, for now. Meeting time now.. :)
</pre>
<br />
<p>- Andrea</p>
<br />
<p>On January 14th, 2011, 2:21 p.m., Furkan Üzümcü wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for rekonq.</div>
<div>By Furkan Üzümcü.</div>
<p style="color: grey;"><i>Updated Jan. 14, 2011, 2:21 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Added support for pinning tabs like Firefox 4 and Google Chrome.
The default preview size was discussed on IRC.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">* Tested and works.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/application.cpp <span style="color: grey">(466a0a4)</span></li>
<li>src/mainview.h <span style="color: grey">(bc8b676)</span></li>
<li>src/mainview.cpp <span style="color: grey">(cbe862f)</span></li>
<li>src/rekonq.kcfg <span style="color: grey">(cda76d8)</span></li>
<li>src/tabbar.h <span style="color: grey">(4170786)</span></li>
<li>src/tabbar.cpp <span style="color: grey">(fcc7b78)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100305/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>