[rekonq] Re: Review Request: GCI Task: Limit the entries in the "Closed Tabs" right-click context menu

[todd rme]

On Tue, Jan 11, 2011 at 12:52 PM, Andrea Diamantini <adjam7 at gmail.com>wrote:

>    This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100315/
>
> On January 11th, 2011, 5:10 p.m., *Andrea Diamantini* wrote:
>
> I don't think this really solves the situation. You should probably limit the "recentlyClosedTabs" list, instead.
>
>  On January 11th, 2011, 5:14 p.m., *Furkan Üzümcü* wrote:
>
> Isn't it used for the closed tabs section on New Tab Page?
> If so people might want to get more closed tabs from there.
>
>  Yes, it is.
> But I think we'll have there the same performance problem you experience in the context menu.
>
>
> - Andrea
>
> On January 7th, 2011, 8:29 p.m., Furkan Üzümcü wrote:
>   Review request for rekonq.
> By Furkan Üzümcü.
>
> *Updated Jan. 7, 2011, 8:29 p.m.*
> Description
>
> After a lon rekonq session, you often have closed *a lot* of tabs. If you then
> accidentaly closed a tab and you want to open it up, rekonq will freeze, while
> the Closed Tabs context menu is loading. This is due to the many entries in
> that menu.
> Limiting the menu to 10 entries would make the situation better.
> This also probably would solve the memory leak, that probably is caused by the
> context menu.
>
> If I use rekonq for a long time, and then close a lot of tabs, the RAM usage of
> rekonq can go as high as 1.5 GB (yes, Gigabyte ;-))
> https://bugs.kde.org/show_bug.cgi?id=240356
>
>   Testing
>
> * Tested and works!
>
>   Diffs
>
>    - src/tabbar.cpp (286d7d4)
>
> View Diff <http://git.reviewboard.kde.org/r/100315/diff/>
>
> _______________________________________________
> rekonq mailing list
> rekonq at kde.org
> https://mail.kde.org/mailman/listinfo/rekonq
>
>
What about letting people independently set the number of items in the
closed tab menu and new tab page?  This may be too many options, but at the
very least probably having 10 or so tabs in the menu and maybe 2 or 3 times
that in the new tab page, either as a fixed value or as a default, would
probably be fine.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110111/3aba54d9/attachment.htm