<br><br><div class="gmail_quote">On Tue, Jan 11, 2011 at 12:52 PM, Andrea Diamantini <span dir="ltr"><<a href="mailto:adjam7@gmail.com">adjam7@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<div>
<div style="font-family: Verdana,Arial,Helvetica,Sans-Serif;"><div class="im">
<table style="border: 1px solid rgb(201, 195, 153);" bgcolor="#f9f3c9" cellpadding="8" width="100%">
<tbody><tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100315/" target="_blank">http://git.reviewboard.kde.org/r/100315/</a>
</td>
</tr>
</tbody></table>
<br>
</div><blockquote style="margin-left: 1em; border-left: 2px solid rgb(208, 208, 208); padding-left: 10px;"><div class="im">
<p style="margin-top: 0pt;">On January 11th, 2011, 5:10 p.m., <b>Andrea Diamantini</b> wrote:</p>
</div><div class="im"><blockquote style="margin-left: 1em; border-left: 2px solid rgb(208, 208, 208); padding-left: 10px;">
<pre style="white-space: pre-wrap; word-wrap: break-word;">I don't think this really solves the situation. You should probably limit the "recentlyClosedTabs" list, instead.</pre>
</blockquote>
</div><div class="im"><p>On January 11th, 2011, 5:14 p.m., <b>Furkan Üzümcü</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid rgb(208, 208, 208); padding-left: 10px;">
<pre style="white-space: pre-wrap; word-wrap: break-word;">Isn't it used for the closed tabs section on New Tab Page?
If so people might want to get more closed tabs from there.</pre>
</blockquote>
</div></blockquote>
<pre style="white-space: pre-wrap; word-wrap: break-word;">Yes, it is.
But I think we'll have there the same performance problem you experience in the context menu.</pre><div class="im">
<br>
<p>- Andrea</p>
<br>
<p>On January 7th, 2011, 8:29 p.m., Furkan Üzümcü wrote:</p>
<table style="background-repeat: repeat-x; border: 1px solid black;" bgcolor="#fefadf" cellpadding="8" cellspacing="0" width="100%">
<tbody><tr>
<td>
<div>Review request for rekonq.</div>
<div>By Furkan Üzümcü.</div>
<p style="color: grey;"><i>Updated Jan. 7, 2011, 8:29 p.m.</i></p>
<h1 style="color: rgb(87, 80, 18); font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table style="border: 1px solid rgb(184, 181, 160);" bgcolor="#ffffff" cellpadding="10" cellspacing="0" width="100%">
<tbody><tr>
<td>
<pre style="margin: 0pt; padding: 0pt; white-space: pre-wrap; word-wrap: break-word;">After a lon rekonq session, you often have closed *a lot* of tabs. If you then
accidentaly closed a tab and you want to open it up, rekonq will freeze, while
the Closed Tabs context menu is loading. This is due to the many entries in
that menu.
Limiting the menu to 10 entries would make the situation better.
This also probably would solve the memory leak, that probably is caused by the
context menu.
If I use rekonq for a long time, and then close a lot of tabs, the RAM usage of
rekonq can go as high as 1.5 GB (yes, Gigabyte ;-))
<a href="https://bugs.kde.org/show_bug.cgi?id=240356" target="_blank">https://bugs.kde.org/show_bug.cgi?id=240356</a></pre>
</td>
</tr>
</tbody></table>
<h1 style="color: rgb(87, 80, 18); font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table style="border: 1px solid rgb(184, 181, 160);" bgcolor="#ffffff" cellpadding="10" cellspacing="0" width="100%">
<tbody><tr>
<td>
<pre style="margin: 0pt; padding: 0pt; white-space: pre-wrap; word-wrap: break-word;">* Tested and works!</pre>
</td>
</tr>
</tbody></table>
<h1 style="color: rgb(87, 80, 18); font-size: 10pt; margin-top: 1.5em;">Diffs </h1>
<ul style="margin-left: 3em; padding-left: 0pt;">
<li>src/tabbar.cpp <span style="color: grey;">(286d7d4)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100315/diff/" style="margin-left: 3em;" target="_blank">View Diff</a></p>
</td>
</tr>
</tbody></table>
</div></div>
</div>
<br>_______________________________________________<br>
rekonq mailing list<br>
<a href="mailto:rekonq@kde.org">rekonq@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/rekonq" target="_blank">https://mail.kde.org/mailman/listinfo/rekonq</a><br>
<br></blockquote></div><br>What about letting people independently set the number of items in the closed tab menu and new tab page? This may be too many options, but at the very least probably having 10 or so tabs in the menu and maybe 2 or 3 times that in the new tab page, either as a fixed value or as a default, would probably be fine.<br>