[rekonq] Re: Review Request: Hide the new tab button if the tab bar is hidden

[Andrea Diamantini]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100335/#review814
-----------------------------------------------------------

Ship it!


Merged together with the UI fixes. This time I couldn't merge your branch directly because the anongit clone is quite slow to update branch...
ah.. I see now you just did :)

- Andrea


On Jan. 9, 2011, 3:04 p.m., Felix Rohrbach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100335/
> -----------------------------------------------------------
> 
> (Updated Jan. 9, 2011, 3:04 p.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> When the option alwaysShowTabBar is enabled, the new tab button should hide. (The bug report says that this bug only happens when you open rekonq, but as I found no handling for showing/hiding the bug I guessed that in all other cases, the button is just overdrawn.)
> 
> Clone: git://anongit.kde.org/clones/rekonq/felixr/rekonq
> Branch: hideNewTabButton
> 
> 
> This addresses bug 262007.
>     /show_bug.cgi?id=262007
> 
> 
> Diffs
> -----
> 
>   src/mainview.cpp 42a7675 
> 
> Diff: http://git.reviewboard.kde.org/r/100335/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Felix
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110109/d588cc2b/attachment.htm