[rekonq] Review Request: Small Memory optimization
Rohan Garg
rohangarg at kubuntu.org
Sun Jan 9 16:35:54 CET 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100336/
-----------------------------------------------------------
Review request for rekonq.
Summary
-------
Some code cleanup:
This patch removes 2 variables notfoundFilePath and isOpened because there are only 2 instances of these variables, one is the declaration and the other is their intialization. Also QFile has isOpen() which can be used to determine whether or not the file is open
Diffs
-----
src/webpage.cpp 4705621
Diff: http://git.reviewboard.kde.org/r/100336/diff
Testing
-------
Compiles and when you open a invalid url displays "Couldn't open the rekonqinfo.html file" ( Which is a bug im working on )
Thanks,
Rohan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110109/64f7c7a6/attachment-0001.htm
More information about the rekonq
mailing list