[rekonq] Re: Review Request: GCI Task: Add support for opening a bookmarks folder in tabs by middle clicking.

[Andrea Diamantini]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100320/#review792
-----------------------------------------------------------



src/bookmarks/bookmarkstoolbar.cpp
<http://git.reviewboard.kde.org/r/100320/#comment593>

    and please... change this to be a 
    switch(event->type())
    {
    case ...
    };
    
    This code is actually unreadable, IMHO.


- Andrea


On Jan. 8, 2011, 8:48 p.m., Furkan Üzümcü wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100320/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2011, 8:48 p.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> Added support for opening a bookmarks folder in tabs by middle clicking.
> 
> 
> Diffs
> -----
> 
>   src/bookmarks/bookmarkstoolbar.cpp e239e23 
> 
> Diff: http://git.reviewboard.kde.org/r/100320/diff
> 
> 
> Testing
> -------
> 
> * Tested and works.
> 
> 
> Thanks,
> 
> Furkan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110109/62bc7bdf/attachment-0001.htm