[rekonq] Re: Review Request: GCI Task: Add support for opening a bookmarks folder in tabs by middle clicking.

[Benjamin Poulain]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100320/#review783
-----------------------------------------------------------



src/bookmarks/bookmarkstoolbar.cpp
<http://git.reviewboard.kde.org/r/100320/#comment585>

    Could you please fix this? It is an aberation. Having a round trip to X there is just wasting cpu.
    
    You can get the global position from the mouse event now that you have added it.



src/bookmarks/bookmarkstoolbar.cpp
<http://git.reviewboard.kde.org/r/100320/#comment586>

    The logic of the contitions is wonky here.
    
    You have something like that:
    if (isGroup && [...])
       ...
    else if (isGroup())
       ...
    
    
    Since this scope is only relevant if isGroup() is true, it should be:
    if (action && action->bookmark().isGroup()) {
        [...] the whole thing
    }



src/bookmarks/bookmarkstoolbar.cpp
<http://git.reviewboard.kde.org/r/100320/#comment587>

    I don't know the use case. Shouldn't that be button == RightButton?
    
    I ask because I see there is a menu in the following block so I guess it is a contextual menu?


- Benjamin


On Jan. 8, 2011, 8:48 p.m., Furkan Üzümcü wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100320/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2011, 8:48 p.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> Added support for opening a bookmarks folder in tabs by middle clicking.
> 
> 
> Diffs
> -----
> 
>   src/bookmarks/bookmarkstoolbar.cpp e239e23 
> 
> Diff: http://git.reviewboard.kde.org/r/100320/diff
> 
> 
> Testing
> -------
> 
> * Tested and works.
> 
> 
> Thanks,
> 
> Furkan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110108/ad136d0d/attachment.htm