[rekonq] Re: Review Request: A bit of cleanup in Application.

[Pierre Rossi]

> On Jan. 7, 2011, 9:31 p.m., Benjamin Poulain wrote:
> > Really cool. I like when a cleaning patch have more - than + :)
> 
> Benjamin Poulain wrote:
>     Oops, forget the ship it :)
>     
>     Please add a scope to those pointer so the destructor is called when the application quits.

Still some nice stats for revision 2:
 src/application.cpp |   88 +++++++++++++++++----------------------------------
 src/application.h   |    8 -----
 2 files changed, 29 insertions(+), 67 deletions(-)


- Pierre


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100316/#review762
-----------------------------------------------------------


On Jan. 8, 2011, 9:51 p.m., Pierre Rossi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100316/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2011, 9:51 p.m.)
> 
> 
> Review request for rekonq and Benjamin Poulain.
> 
> 
> Summary
> -------
> 
> I believe we don't need static members in QWeakPointers for all the *Managers, static getter functions would do the job.
> 
> 
> This addresses bug N/A.
>     /show_bug.cgi?id=N/A
> 
> 
> Diffs
> -----
> 
>   src/application.h b30e337 
>   src/application.cpp 466a0a4 
> 
> Diff: http://git.reviewboard.kde.org/r/100316/diff
> 
> 
> Testing
> -------
> 
> "compiles and runs" ™
> 
> 
> Thanks,
> 
> Pierre
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110108/5ec111b4/attachment.htm