[rekonq] Re: Review Request: A bit of cleanup in Application.

[Pierre Rossi]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100316/
-----------------------------------------------------------

(Updated Jan. 8, 2011, 9:51 p.m.)


Review request for rekonq and Benjamin Poulain.


Changes
-------

Sure, QScopedPointer is so nice, it'd be a waste not to use it. :)


Summary
-------

I believe we don't need static members in QWeakPointers for all the *Managers, static getter functions would do the job.


This addresses bug N/A.
    /show_bug.cgi?id=N/A


Diffs (updated)
-----

  src/application.h b30e337 
  src/application.cpp 466a0a4 

Diff: http://git.reviewboard.kde.org/r/100316/diff


Testing
-------

"compiles and runs" ™


Thanks,

Pierre

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110108/d4c444ec/attachment.htm