[rekonq] Re: Review Request: GCI Task: Limit the entries in the "Closed Tabs" right-click context menu

[todd rme]

2011/1/7 Furkan Üzümcü <furkanuzumcu at gmail.com>

>    This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100315/
>   Review request for rekonq.
> By Furkan Üzümcü.
> Description
>
> After a lon rekonq session, you often have closed *a lot* of tabs. If you then
> accidentaly closed a tab and you want to open it up, rekonq will freeze, while
> the Closed Tabs context menu is loading. This is due to the many entries in
> that menu.
> Limiting the menu to 5 entries would make the situation better.
> This also probably would solve the memory leak, that probably is caused by the
> context menu.
>
> If I use rekonq for a long time, and then close a lot of tabs, the RAM usage of
> rekonq can go as high as 1.5 GB (yes, Gigabyte ;-))
> https://bugs.kde.org/show_bug.cgi?id=240356
>
>   Testing
>
> * Tested and works!
>
>   Diffs
>
>    - src/tabbar.cpp (286d7d4)
>
> View Diff <http://git.reviewboard.kde.org/r/100315/diff/>
>
> _______________________________________________
> rekonq mailing list
> rekonq at kde.org
> https://mail.kde.org/mailman/listinfo/rekonq
>
>

I think limiting it to 10 entries would be better.  5 seems too small to me,
I often want to go back further than that.  10 seems a reasonable
compromise.  10 also seems to be what firefox uses (although I don't know if
this is in vanilla firefox or due to tab mix plus).
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110107/fa5a2c3a/attachment.htm