<div class="gmail_quote">2011/1/7 Furkan Üzümcü <span dir="ltr"><<a href="mailto:furkanuzumcu@gmail.com">furkanuzumcu@gmail.com</a>></span><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<div>
<div style="font-family: Verdana,Arial,Helvetica,Sans-Serif;">
<table style="border: 1px solid rgb(201, 195, 153);" bgcolor="#f9f3c9" cellpadding="8" width="100%">
<tbody><tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100315/" target="_blank">http://git.reviewboard.kde.org/r/100315/</a>
</td>
</tr>
</tbody></table>
<br>
<table style="background-repeat: repeat-x; border: 1px solid black;" bgcolor="#fefadf" cellpadding="8" cellspacing="0" width="100%">
<tbody><tr>
<td>
<div>Review request for rekonq.</div>
<div>By Furkan Üzümcü.</div>
<h1 style="color: rgb(87, 80, 18); font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table style="border: 1px solid rgb(184, 181, 160);" bgcolor="#ffffff" cellpadding="10" cellspacing="0" width="100%">
<tbody><tr>
<td>
<pre style="margin: 0pt; padding: 0pt; white-space: pre-wrap; word-wrap: break-word;">After a lon rekonq session, you often have closed *a lot* of tabs. If you then
accidentaly closed a tab and you want to open it up, rekonq will freeze, while
the Closed Tabs context menu is loading. This is due to the many entries in
that menu.
Limiting the menu to 5 entries would make the situation better.
This also probably would solve the memory leak, that probably is caused by the
context menu.
If I use rekonq for a long time, and then close a lot of tabs, the RAM usage of
rekonq can go as high as 1.5 GB (yes, Gigabyte ;-))
<a href="https://bugs.kde.org/show_bug.cgi?id=240356" target="_blank">https://bugs.kde.org/show_bug.cgi?id=240356</a></pre>
</td>
</tr>
</tbody></table>
<h1 style="color: rgb(87, 80, 18); font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table style="border: 1px solid rgb(184, 181, 160);" bgcolor="#ffffff" cellpadding="10" cellspacing="0" width="100%">
<tbody><tr>
<td>
<pre style="margin: 0pt; padding: 0pt; white-space: pre-wrap; word-wrap: break-word;">* Tested and works!</pre>
</td>
</tr>
</tbody></table>
<h1 style="color: rgb(87, 80, 18); font-size: 10pt; margin-top: 1.5em;">Diffs </h1>
<ul style="margin-left: 3em; padding-left: 0pt;">
<li>src/tabbar.cpp <span style="color: grey;">(286d7d4)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100315/diff/" style="margin-left: 3em;" target="_blank">View Diff</a></p>
</td>
</tr>
</tbody></table>
</div>
</div>
<br>_______________________________________________<br>
rekonq mailing list<br>
<a href="mailto:rekonq@kde.org">rekonq@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/rekonq" target="_blank">https://mail.kde.org/mailman/listinfo/rekonq</a><br>
<br></blockquote></div><br><br>I think limiting it to 10 entries would be better. 5 seems too small to me, I often want to go back further than that. 10 seems a reasonable compromise. 10 also seems to be what firefox uses (although I don't know if this is in vanilla firefox or due to tab mix plus).<br>