[rekonq] Re: Review Request: The find bar is now closed with esc even with a shortcut override

[Andrea Diamantini]

> On Feb. 7, 2011, 9:21 p.m., Pierre Rossi wrote:
> > src/mainwindow.cpp, line 1123
> > <http://git.reviewboard.kde.org/r/100538/diff/5/?file=8552#file8552line1123>
> >
> >     What if it's a QShortcutEvent ?
> >

I'm seeing in the docs that QEvent::ShortcutOverride && QEvent::KeyPress ARE QKeyEvent(s). So, the assertion and the static_cast are safe. Am I missing something?


- Andrea


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100538/#review1299
-----------------------------------------------------------


On Feb. 6, 2011, 9:33 a.m., Yoann Laissus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100538/
> -----------------------------------------------------------
> 
> (Updated Feb. 6, 2011, 9:33 a.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> When the user defines a custom action for the esc key, the findbar isn't hidden with this key. This patch solves it.
> 
> 
> This addresses bug 264929.
>     /show_bug.cgi?id=264929
> 
> 
> Diffs
> -----
> 
>   src/mainwindow.h 33fd20212b9bb69d9450298e4e43324885f8bdf0 
>   src/mainwindow.cpp f662d7aa77d8045372c43514c6a04ea497a9afbc 
> 
> Diff: http://git.reviewboard.kde.org/r/100538/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Yoann
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110207/bddfc603/attachment.htm