[rekonq] Re: Review Request: The find bar is now closed with esc even with a shortcut override

[Pierre Rossi]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100538/#review1299
-----------------------------------------------------------


Apart from the minor style issues, my concern is more for the QShortcutEvent case, I believe a switch on the event type in which we'd check for the escape key and then set a flag would be safer.


src/mainwindow.cpp
<http://git.reviewboard.kde.org/r/100538/#comment1081>

    What if it's a QShortcutEvent ?
    



src/mainwindow.cpp
<http://git.reviewboard.kde.org/r/100538/#comment1082>

    Unnecessary blank line, or at least leading white space issue.



src/mainwindow.cpp
<http://git.reviewboard.kde.org/r/100538/#comment1083>

    Style: trailing whitespace


- Pierre


On Feb. 6, 2011, 9:33 a.m., Yoann Laissus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100538/
> -----------------------------------------------------------
> 
> (Updated Feb. 6, 2011, 9:33 a.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> When the user defines a custom action for the esc key, the findbar isn't hidden with this key. This patch solves it.
> 
> 
> This addresses bug 264929.
>     /show_bug.cgi?id=264929
> 
> 
> Diffs
> -----
> 
>   src/mainwindow.h 33fd20212b9bb69d9450298e4e43324885f8bdf0 
>   src/mainwindow.cpp f662d7aa77d8045372c43514c6a04ea497a9afbc 
> 
> Diff: http://git.reviewboard.kde.org/r/100538/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Yoann
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110207/59138f5f/attachment.htm