[rekonq] Re: Tab Preview Size

[Pierre Rossi]

On Wed, Feb 2, 2011 at 00:43, Furkan Üzümcü <furkanuzumcu at gmail.com> wrote:

> On 02.02.2011 01:36, Panagiotis Papadopoulos wrote:
> > Am Mittwoch 02 Februar 2011, 01:31:10 schrieb Furkan Üzümcü:
> >> Hello.
> >> As the number of tabs increases the size of the tab previews decrease.
> >> We need to find a base size for tab previews.
> >> Does anyone have an opinion on it?
> >>
> >>
> > I like the approach of the tab previews you used in your pin tabs feature
> :-) ;-)
> > _______________________________________________
> > rekonq mailing list
> > rekonq at kde.org
> > https://mail.kde.org/mailman/listinfo/rekonq
> Height = 150
> Width = 200
> I also like this approach but Pierre Rossi told me not to hard code the
> size. He may change his mind. If no one comes up with a better idea I
> guess we HAVE TO use this approach because previews that get smaller as
> the number of tabs increases aren't good!
>
> --
> Regards,
> Furkan Üzümcü
>
> _______________________________________________
> rekonq mailing list
> rekonq at kde.org
> https://mail.kde.org/mailman/listinfo/rekonq
>

I guess it's fine to hardcode the width and have a hint for the height or
aspect ratio (to avoid displaying streched previews), but please put that in
a constant (static const int at the top of the file).

Cheers,
--
Pierre
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110207/ac2a055b/attachment.htm