[rekonq] Re: Review Request: Make rekonq desktop aware

[Felix Rohrbach]

> On April 5, 2011, 10:23 p.m., Andrea Diamantini wrote:
> > src/application.cpp, line 442
> > <http://git.reviewboard.kde.org/r/101033/diff/1/?file=13806#file13806line442>
> >
> >     Uhm... I don't like this. Can't we do it in mainwindow ctor?

Of course we can, I'll do it.


> On April 5, 2011, 10:23 p.m., Andrea Diamantini wrote:
> > src/application.cpp, line 679
> > <http://git.reviewboard.kde.org/r/101033/diff/1/?file=13806#file13806line679>
> >
> >     Thinking a bit more, I don't understand the real need for this.
> >     What is the foreach cycle added for, then?

The foreach loop is to prefer windows on the current desktop. This one is to prefer the last activated window on this desktop or all other desktops if there is no window on the current desktop.


- Felix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101033/#review2417
-----------------------------------------------------------


On April 5, 2011, 9:44 p.m., Felix Rohrbach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101033/
> -----------------------------------------------------------
> 
> (Updated April 5, 2011, 9:44 p.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> If there is a rekonq window on the current virtual desktop and another application opens a link, rekonq will prefer this window. With this patch, rekonq also prefers windows that were activated most recently (old behaviour: most recently created).
> 
> branch: desktopAware
> 
> 
> This addresses bug 237732.
>     /show_bug.cgi?id=237732
> 
> 
> Diffs
> -----
> 
>   src/application.h 3cd3c96 
>   src/application.cpp 1fe936f 
>   src/mainwindow.h 9853ca3 
>   src/mainwindow.cpp 7b4e3ee 
> 
> Diff: http://git.reviewboard.kde.org/r/101033/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Felix
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110406/d1f958b6/attachment.htm