[rekonq] Re: Review Request: Make rekonq desktop aware

[Andrea Diamantini]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101033/#review2417
-----------------------------------------------------------



src/application.h
<http://git.reviewboard.kde.org/r/101033/#comment2074>

    trailing spaces



src/application.cpp
<http://git.reviewboard.kde.org/r/101033/#comment2075>

    Q_FOREACH, please.



src/application.cpp
<http://git.reviewboard.kde.org/r/101033/#comment2076>

    Uhm... I don't like this. Can't we do it in mainwindow ctor?



src/application.cpp
<http://git.reviewboard.kde.org/r/101033/#comment2077>

    Thinking a bit more, I don't understand the real need for this.
    What is the foreach cycle added for, then?



src/mainwindow.h
<http://git.reviewboard.kde.org/r/101033/#comment2078>

    trailing spaces



src/mainwindow.cpp
<http://git.reviewboard.kde.org/r/101033/#comment2079>

    trailing spaces.


- Andrea


On April 5, 2011, 9:44 p.m., Felix Rohrbach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101033/
> -----------------------------------------------------------
> 
> (Updated April 5, 2011, 9:44 p.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> If there is a rekonq window on the current virtual desktop and another application opens a link, rekonq will prefer this window. With this patch, rekonq also prefers windows that were activated most recently (old behaviour: most recently created).
> 
> branch: desktopAware
> 
> 
> This addresses bug 237732.
>     /show_bug.cgi?id=237732
> 
> 
> Diffs
> -----
> 
>   src/application.h 3cd3c96 
>   src/application.cpp 1fe936f 
>   src/mainwindow.h 9853ca3 
>   src/mainwindow.cpp 7b4e3ee 
> 
> Diff: http://git.reviewboard.kde.org/r/101033/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Felix
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110405/8ffd298d/attachment.htm