[rekonq] Re: Review Request: Fix quit/close actions

[Felix Rohrbach]

> On April 4, 2011, 8:29 a.m., Andrea Diamantini wrote:
> > src/mainwindow.cpp, line 362
> > <http://git.reviewboard.kde.org/r/101019/diff/2/?file=13727#file13727line362>
> >
> >     is kApplication() really right? Does this code compile?

It should be the same as qApp, see http://api.kde.org/4.x-api/kdelibs-apidocs/kdeui/html/classKApplication.html#a2cc5e559fa8a7b365e7eb9a024fd2e41 . Afaik it doesn't matter which one to use for this, but I read some KDE rule saying "in doubt, prefer the KDE variant over the Qt variant", so I took the KDE one. And it compiles, of course.


> On April 4, 2011, 8:29 a.m., Andrea Diamantini wrote:
> > src/mainwindow.cpp, line 366
> > <http://git.reviewboard.kde.org/r/101019/diff/2/?file=13727#file13727line366>
> >
> >     Why that?

remove the alternate shortcut, see below.


> On April 4, 2011, 8:29 a.m., Andrea Diamantini wrote:
> > src/mainwindow.cpp, line 499
> > <http://git.reviewboard.kde.org/r/101019/diff/2/?file=13727#file13727line499>
> >
> >     Why?

Up to now, the close shortcuts were used to close tabs, so when I added the standard close action, the shortcuts were used two times. My resolution was to give the tab close the primary shortcut of KStandardAction::close (CTRL+W) and the window close the alternate shortcut (CTRL+Esc). Maybe I can write that a bit cleaner...


- Felix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101019/#review2376
-----------------------------------------------------------


On April 3, 2011, 4:31 p.m., Felix Rohrbach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101019/
> -----------------------------------------------------------
> 
> (Updated April 3, 2011, 4:31 p.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> The quit action in the action collection did just close the current rekonq window instead of quitting the application, so I added a close action and fixed the quit action.
> 
> branch: quitClose
> 
> 
> This addresses bug 268578.
>     /show_bug.cgi?id=268578
> 
> 
> Diffs
> -----
> 
>   src/mainwindow.cpp 3489841 
> 
> Diff: http://git.reviewboard.kde.org/r/101019/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Felix
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110404/ee0c7736/attachment.htm