[rekonq] Re: Review Request: Fix quit/close actions

[Andrea Diamantini]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101019/#review2376
-----------------------------------------------------------



src/mainwindow.cpp
<http://git.reviewboard.kde.org/r/101019/#comment2039>

    is kApplication() really right? Does this code compile?



src/mainwindow.cpp
<http://git.reviewboard.kde.org/r/101019/#comment2040>

    Why that?



src/mainwindow.cpp
<http://git.reviewboard.kde.org/r/101019/#comment2041>

    Why?


- Andrea


On April 3, 2011, 4:31 p.m., Felix Rohrbach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101019/
> -----------------------------------------------------------
> 
> (Updated April 3, 2011, 4:31 p.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> The quit action in the action collection did just close the current rekonq window instead of quitting the application, so I added a close action and fixed the quit action.
> 
> branch: quitClose
> 
> 
> This addresses bug 268578.
>     /show_bug.cgi?id=268578
> 
> 
> Diffs
> -----
> 
>   src/mainwindow.cpp 3489841 
> 
> Diff: http://git.reviewboard.kde.org/r/101019/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Felix
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110404/d06b581b/attachment-0001.htm