[rekonq] Re: Fwd: Re: Review Request: Optimize rekonq protocol handling

[Benjamin Poulain]

On 10/20/2010 10:40 AM, ext andrea diamantini wrote:
> ---------- Forwarded message ----------
> From: *andrea diamantini* <adjam7 at gmail.com <mailto:adjam7 at gmail.com>>
> Date: 2010/10/20
> Subject: Re: [rekonq] Re: Review Request: Optimize rekonq protocol handling
> To: Lionel Chauvin <megabigbug at yahoo.fr <mailto:megabigbug at yahoo.fr>>
>
>
> Yes, the motivation for this is just because I consider them more
> readable. But in general, considering that people is used on Qt/KDE
> conventions (converging on brackets), I'm not too strict on.
> To fix code style, we have a script in the scripts dir.

That is the beauty of coding style, everyone think his own is better ;)

Personally, I think most coding style have the same value when it comes 
to readability (well, fine, not the coding style of harfbuzz ;) ).

What is important in my opinion is consistency. Being consistent with 
KDE, Qt and/or WebKit would be nice. If it is not the path chosen, being 
consistent inside Rekonq is a must have, in my opinion.

I only learned recently that Rekonq does not follow KDE coding style so 
I am also guilty of pushing inconsistent style inside the project. I 
would prefer if we could fix the style where it is not consistent and 
then ensure it stays consistent by also checking that when doing reviews.

For the WebKit project, we are very strict about coding style. Patches 
are rejected right away when the style is not perfect. This pays off for 
us I think. When you read the code of WebKit, you are never interrupted 
because your mind noticed a bracket at the wrong position. You can focus 
on what is important.
The coding style is here: http://webkit.org/coding/coding-style.html

cheers,
Benjamin