[rekonq] Re: Review Request: 'make buildtests' fixed

Andrea Diamantini adjam7 at gmail.com
Wed Oct 13 23:38:33 CEST 2010



> On 2010-10-13 20:40:58, Andrea Diamantini wrote:
> > This is the right way, yes :)
> > Please, commit it yourself!
> 
> Jon Ander Peñalba wrote:
>     Where should I commit it? The main repo?
>     I'm not a KDE developer yet :)

I was testing your attention... :)
Ok, committing it..


- Andrea


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100060/#review87
-----------------------------------------------------------


On 2010-10-12 17:08:56, Jon Ander Peñalba wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100060/
> -----------------------------------------------------------
> 
> (Updated 2010-10-12 17:08:56)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> Two necessary includes added to the protocol test so that 'make buildtests' can finish without errors.
> 
> PS: I'm not quite sure if this is the best way to send merge request now. So please tell me if it isn't :)
> 
> 
> Diffs
> -----
> 
>   src/tests/protocolhandler_test.cpp cadff33 
> 
> Diff: http://git.reviewboard.kde.org/r/100060/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jon Ander
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20101013/502d6f54/attachment.htm 


More information about the rekonq mailing list