[rekonq] Re: Review Request: API clean up urlBar --> currentUrlBar

Andrea Diamantini adjam7 at gmail.com
Sun Nov 7 23:43:59 CET 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100140/
-----------------------------------------------------------

(Updated 2010-11-07 22:43:59.011914)


Review request for rekonq.


Summary (updated)
-------

API clean up urlBar --> currentUrlBar

Yuppi!!!
Finally a working merge request with the post-review tool :D
To obtain it I used the following:
- Done everything explained here (http://community.kde.org/Sysadmin/GitKdeOrgManual#Using_ReviewBoard_and_post-review)
- Performed merge request with the following command
$ post-review --parent=master --tracking-branch=anonupstream/master --guess-description --guess-summary --branch=master --target-groups=rekonq -p

:D


Diffs
-----

  src/application.cpp 2efb62c081ed7cc1ae5db9e2e3de1ff5f8bef20c 
  src/mainview.h 29162dd1875166747898a0453b331453c93a0624 
  src/mainview.cpp beaf4e21e24ed5d536a8aeea2966c1e35b556823 
  src/mainwindow.cpp d5f82d97715f406cd9c7a194bfa5c069c2d8ce71 
  src/protocolhandler.cpp a29ff366186b9cf1b523536ac3a60bd91f4bb5c9 
  src/webview.cpp 8be744ade071fabfd1c602099d51b52af93d531c 

Diff: http://git.reviewboard.kde.org/r/100140/diff


Testing
-------


Thanks,

Andrea

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20101107/9e65e4f0/attachment.htm 


More information about the rekonq mailing list