[rekonq] bug #237390

Mathias Kraus k.hias at gmx.de
Fri Jun 4 01:46:24 CEST 2010


hi,

I'm affected with bug #237390 [1], so I decided to have a look at it.
attached is a bookmark file with 10000 entries. if you use it with the current 
rekonq, don't type anything in the urlbar. it will freeze and take very long 
to respond again.
with the attached patch, you get almost immediately the completion list.
basically I extendet UrlSearchItem and replaced the KUrl with a QString, 
because that had a negative effect to performance. beside 
UrlResolver::privilegedItem it wasn't needed anyway and I found a good 
workaround for that. the completion now also works for titles, not only for 
urls.
at the moment the startup speed is negatively affected with many bookmarks, 
but as rekonq is unusable with that many bookmarks, this shouldn't matter at 
the moment. I don't really know what happens when loading the bookmarks, 
because konqueror startup isn't affected and also the unpatched rekonq.

what do you think about the patch? shall I continue on it?

regards,
mathias


[1] http://bugs.kde.org/show_bug.cgi?id=237390
-------------- next part --------------
A non-text attachment was scrubbed...
Name: awesomebar_speed.diff
Type: text/x-patch
Size: 25622 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/rekonq/attachments/20100604/868fa87c/attachment-0001.diff 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bookmarks.tar.bz2
Type: application/x-bzip-compressed-tar
Size: 46403 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/rekonq/attachments/20100604/868fa87c/attachment-0001.tbz2 


More information about the rekonq mailing list