[rekonq] problems with trailing spaces in some urls
thomas gahr
thomas.gahr at physik.uni-muenchen.de
Mon Feb 1 19:42:00 CET 2010
>
> Hi Thomas,
> Your patch just removes a blank line.. :)
>
> To produce a right patch with git you should:
> - sync your master with gitorious
> - everytime create a new branch to work on
> - ... code ...
>
> Now, if you won't commit it, just
> $ git diff > yourfix.patch
>
> if you wanna commit, then commit it :) and
> $ git diff HEAD > yourfix.patch
>
> if you wanna create a patch with e.g. your last 3 commits,
> $ git diff HEAD~2 > yourfix.patch
>
> Good luck (and welcome aboard)!
well, it removes a blank line in application.cpp - i noticed that but after
going back and forth with git reset just to get rid of dozens of other stuff i
added that wasn't needed (it was late and i was tired that day ;) ) i figured
that this line won't hurt...
it does modify urlbar.cpp, though - can it be that you opened it with kompare?
just did the same and was shocked to only see that single line changed - until
i clicked the urlbar-folder :)
anyway, thanks for the hints, clarified a few things.
More information about the rekonq
mailing list