[rekonq] problems with trailing spaces in some urls

[Andrea Diamantini]

On Friday 29 January 2010 02:09:46 thomas gahr wrote:
> Hi!
> 
> I already reported a bug about this today:
> https://bugs.kde.org/show_bug.cgi?id=224636
> well, i can't reproduce the first part of it (although i did get that
> behaviour everytime i tried it this afternoon... can't figure out why...)
> but the second part still persists:
> in some urls, trailing spaces are converted to %20 . for example:
> "http://www.google.de/ "		doesn't work (%20)
> "www.google.de "			does work
> "http://www.google.de "		doesn't work (url gets changed to "http:")
> 
> i poked around in the sources and i found a solution, though there might be
> a more elegant one...
> 
> my first commit ever to a kde project, so... be kind ;)
> 
> btw: stumbled upon rekonq just today and i love it! you're doing a great
> job!

Hi Thomas,
Your patch just removes a blank line.. :)

To produce a right patch with git you should:
- sync your master with gitorious
- everytime create a new branch to work on
- ... code ...

Now, if you won't commit it, just 
$ git diff > yourfix.patch

if you wanna commit, then commit it :) and 
$ git diff HEAD > yourfix.patch

if you wanna create a patch with e.g. your last 3 commits,
$ git diff HEAD~2 > yourfix.patch

Good luck (and welcome aboard)!
 
-- 
Andrea Diamantini, adjam
GPG Fingerprint: 57DE 8E32 7D1A 0E16 AA52 59D8 84F9 3ECD DBF9 730F

rekonq project
WEB: http://rekonq.sourceforge.net
IRC: rekonq at freenode