[rekonq] Re: Review Request: highlight updated tabs

Andrea Diamantini adjam7 at gmail.com
Fri Dec 31 11:50:48 CET 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100230/#review680
-----------------------------------------------------------


uhm... I actually have "Desktop Effects" disabled here, not sure if this is important, but I see a strange blue rectangle covering the hightlighted tab. Not really good :(

- Andrea


On 2010-12-29 23:16:20, Johannes Tröscher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100230/
> -----------------------------------------------------------
> 
> (Updated 2010-12-29 23:16:20)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> This patch highlights inactive tabs if their title has changed, so people get aware of changes in the tabs (for instance a new message in a chat window).
> 
> I don't have a kde git account, so please merge it if you like it.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 6cf2651 
>   src/mainview.cpp 850101e 
>   src/tabbar.h acd8e2f 
>   src/tabbar.cpp 286d7d4 
>   src/tabhighlighteffect.h PRE-CREATION 
>   src/tabhighlighteffect.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/100230/diff
> 
> 
> Testing
> -------
> 
> compiles and works
> 
> 
> Thanks,
> 
> Johannes
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20101231/7d066a68/attachment.htm 


More information about the rekonq mailing list