[rekonq] Re: Review Request: highlight updated tabs

[Johannes Tröscher]

> On 2010-12-30 16:49:46, Pierre Rossi wrote:
> > It seems pretty good apart from the graphicseffect's class name and lack of genericity (could be refactored in the future).
> > I don't have much time for a more detailed review before next week, but if someone's nice enough to test it and say they like it, I think it could safely be integrated in master at least.

what would you think about this implementation: http://paste.kde.org/1458/ ?
i'm not really satisfied with the look of the current implementation, because tabRect() returns a rect that is bigger than the tab itself is drawn.
i'd rather animate the text, but if i use QGraphicsEffect and try to animate elided text the result differs if i use different application styles(oxygen, plastique). They draw their tabs in different sizes. if i'd call QFontMetrics::elidedText for their tabRect and tabText i'd get different strings as result.


- Johannes


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100230/#review666
-----------------------------------------------------------


On 2010-12-29 23:16:20, Johannes Tröscher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100230/
> -----------------------------------------------------------
> 
> (Updated 2010-12-29 23:16:20)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> This patch highlights inactive tabs if their title has changed, so people get aware of changes in the tabs (for instance a new message in a chat window).
> 
> I don't have a kde git account, so please merge it if you like it.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 6cf2651 
>   src/mainview.cpp 850101e 
>   src/tabbar.h acd8e2f 
>   src/tabbar.cpp 286d7d4 
>   src/tabhighlighteffect.h PRE-CREATION 
>   src/tabhighlighteffect.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/100230/diff
> 
> 
> Testing
> -------
> 
> compiles and works
> 
> 
> Thanks,
> 
> Johannes
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20101230/61d59326/attachment-0001.htm