[rekonq] Re: Review Request: Add a tab list menu to the corner widget

Felix Rohrbach fxrh at gmx.de
Tue Dec 28 16:00:14 CET 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100253/
-----------------------------------------------------------

(Updated 2010-12-28 15:00:14.612813)


Review request for rekonq.


Changes
-------

Fixed the wrong position of the new tab button. And Andrea: I checked the height (with this new patch and without any patch) of the tabs with screenshots with 200% magnification and there were no differences in the tab heights. Screenshots: http://dl.dropbox.com/u/635584/vergleich.png http://dl.dropbox.com/u/635584/vergleich2.png 

Maybe that new button could also be used to open the tab list page, then I would suggest to merge this patch and then create the tab list page on top of that (and keep an option for using the tab list menu, if I'm not the only one who likes it). 


Summary
-------

This patch adds a tool button to the corner widget of the tab widget which shows a list of the current open tabs. In contrast to the open new tab button this button is always in the top right edge.


Diffs (updated)
-----

  src/mainview.h 1d04d28 
  src/mainview.cpp 850101e 
  src/mainwindow.cpp 3a9c124 

Diff: http://git.reviewboard.kde.org/r/100253/diff


Testing
-------

Tested and works well.


Thanks,

Felix

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20101228/4c3e35a2/attachment.htm 


More information about the rekonq mailing list