[rekonq] Re: Review Request: Add a tab list menu to the corner widget

[Andrea Diamantini]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100253/#review637
-----------------------------------------------------------


I personally don't like this change. We have a bug report open, asking about a "tab list page": I prefer that solution.
Moreover, your implementation breaks tabs & new tab button alignment.

- Andrea


On 2010-12-27 19:44:32, Felix Rohrbach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100253/
> -----------------------------------------------------------
> 
> (Updated 2010-12-27 19:44:32)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> This patch adds a tool button to the corner widget of the tab widget which shows a list of the current open tabs. In contrast to the open new tab button this button is always in the top right edge.
> 
> 
> Diffs
> -----
> 
>   src/mainview.h 1d04d28 
>   src/mainview.cpp 850101e 
>   src/mainwindow.cpp 3a9c124 
> 
> Diff: http://git.reviewboard.kde.org/r/100253/diff
> 
> 
> Testing
> -------
> 
> Tested and works well.
> 
> 
> Thanks,
> 
> Felix
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20101227/f45b0433/attachment-0001.htm