[rekonq] Re: Review Request: highlight updated tabs
Pierre Rossi
pierre.rossi at gmail.com
Tue Dec 28 09:57:05 CET 2010
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100230/#review643
-----------------------------------------------------------
I think the code for this could be a bit more compact, and maintainable. And I'd probably like it better if there was nothing happening in the event handler.
src/tabbar.h
<http://git.reviewboard.kde.org/r/100230/#comment469>
I don't think you need this, you could start the animation with DeleteWhenStopped deletion policy.
src/tabbar.h
<http://git.reviewboard.kde.org/r/100230/#comment470>
Which means you don't need to keep a list either.
src/tabbar.h
<http://git.reviewboard.kde.org/r/100230/#comment473>
And I think you could probably do without this.
src/tabbar.cpp
<http://git.reviewboard.kde.org/r/100230/#comment471>
a static const int would be better IMO. (I know we still have ugly defines in rekonq, let's not add more) :)
src/tabbar.cpp
<http://git.reviewboard.kde.org/r/100230/#comment472>
I'm not a big fan of this, couldn't you apply a graphics effect instead ?
- Pierre
On 2010-12-27 20:49:03, Johannes Tröscher wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100230/
> -----------------------------------------------------------
>
> (Updated 2010-12-27 20:49:03)
>
>
> Review request for rekonq.
>
>
> Summary
> -------
>
> This patch highlights inactive tabs if their title has changed, so people get aware of changes in the tabs (for instance a new message in a chat window).
>
> I don't have a kde git account, so please merge it if you like it.
>
>
> Diffs
> -----
>
> src/mainview.cpp 850101e
> src/tabbar.h acd8e2f
> src/tabbar.cpp 286d7d4
>
> Diff: http://git.reviewboard.kde.org/r/100230/diff
>
>
> Testing
> -------
>
> compiles and works
>
>
> Thanks,
>
> Johannes
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20101228/2c79858e/attachment.htm
More information about the rekonq
mailing list