[rekonq] Re: Review Request: highlight updated tabs

Johannes Tröscher fritz_van_tom at hotmail.com
Mon Dec 27 23:48:34 CET 2010



> On 2010-12-27 22:41:45, Andrea Diamantini wrote:
> > I cannot properly comment on this patch code. I can say I like this feature, but NOT the "strange blue" used to highlight the tab.. :)

it uses the "highlight" color of the active palette. what color would you like to highlight the tabs?


- Johannes


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100230/#review639
-----------------------------------------------------------


On 2010-12-27 20:49:03, Johannes Tröscher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100230/
> -----------------------------------------------------------
> 
> (Updated 2010-12-27 20:49:03)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> This patch highlights inactive tabs if their title has changed, so people get aware of changes in the tabs (for instance a new message in a chat window).
> 
> I don't have a kde git account, so please merge it if you like it.
> 
> 
> Diffs
> -----
> 
>   src/mainview.cpp 850101e 
>   src/tabbar.h acd8e2f 
>   src/tabbar.cpp 286d7d4 
> 
> Diff: http://git.reviewboard.kde.org/r/100230/diff
> 
> 
> Testing
> -------
> 
> compiles and works
> 
> 
> Thanks,
> 
> Johannes
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20101227/452749df/attachment.htm 


More information about the rekonq mailing list