[rekonq] Re: Review Request: GCI Task: Context menu improvements

[Benjamin Poulain]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100167/#review495
-----------------------------------------------------------



src/webview.h
<http://git.reviewboard.kde.org/r/100167/#comment375>

    Those comments should not be here. They could be in the cpp file, before the function, but not here after the prototype.



src/webview.cpp
<http://git.reviewboard.kde.org/r/100167/#comment376>

    I would prefer a new temp variable:
    KAction *const findAction = ...
    menu.addAction(findAction);



src/webview.cpp
<http://git.reviewboard.kde.org/r/100167/#comment377>

    This is invalid IMHO. I would build a KUrl with the text and use KUrl::isValid() to assert of the validity of the Url.



src/webview.cpp
<http://git.reviewboard.kde.org/r/100167/#comment381>

    The comment should be on the line before, not after the code.
    
    The comment should end with a dot since it is a complete sentence (like on WebKit ... :)).



src/webview.cpp
<http://git.reviewboard.kde.org/r/100167/#comment380>

    Please give a better name to the variable "a".



src/webview.cpp
<http://git.reviewboard.kde.org/r/100167/#comment378>

    Invalid indentation.



src/webview.cpp
<http://git.reviewboard.kde.org/r/100167/#comment379>

    Please give a better name to the variable "a".


- Benjamin


On 2010-11-24 16:54:44, Nikhil Shantanu Marathe wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100167/
> -----------------------------------------------------------
> 
> (Updated 2010-11-24 16:54:44)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> This was a Google Code In 2010 task. Context menu improvements are by Furkan Uzumcu <furkanuzumcu at gmail.com>. They include:
> 
> * Find... and Print... actions in context menu
> * Detect URL like selected text and offer to treat it as a URL and open in new window/tab
> * View Image in new Tab
> 
> 
> Diffs
> -----
> 
>   src/mainwindow.h 33fd202 
>   src/webview.h 9518b74 
>   src/webview.cpp 7664805 
> 
> Diff: http://git.reviewboard.kde.org/r/100167/diff
> 
> 
> Testing
> -------
> 
> Tested and works OK.
> 
> 
> Thanks,
> 
> Nikhil Shantanu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20101212/ae9228be/attachment.htm