[rekonq] MainView refactoring proposal

Domrachev Alexandr alexandr.domrachev at gmail.com
Wed Apr 8 16:26:38 CEST 2009


Hi!

On 8 апреля 2009 18:00:59 Paweł Prażak wrote:
> I'm thinking about adding another layer of abstraction between mainView and
> urlBar / webView pair something like webTab class or something, because
> MainView is too big and have to many responsibilities and it's hard to
> understand because of it, not to mention debugging it.
>
> I think that by adding another level of abstraction we can achieve better
> encapsulation and clearer code. We would have clear responsibility.
> MainView (TabWidget) contains WebTabs and every WebTab contains WebView and
> UrlBar. Now we have situation when MainView is involved in creating new
> tabs in pieces so IMO there is greater possibility of introducing a bug. I
> matter of facts, we have a new one I introduced while porting UrlBar to
> KDE.
>
> Maybe I'll try it out in a branch and show you what I mean. What do you
> think?
>
> --
> Paweł

Seems it would be the best solution.

-- 
С уважением,
    Домрачев Александр.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20090408/824cb540/attachment.htm 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/rekonq/attachments/20090408/824cb540/attachment.sig 


More information about the rekonq mailing list