Review Request 116067: Implement WebSocket type.

Nikita Skovoroda chalkerx at gmail.com
Fri Feb 28 23:14:16 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116067/#review51401
-----------------------------------------------------------


It still has wrong behavior if url is changed while the socket is in Connecting state.

I am not sure how it should work in this case, will look at it a bit later (maybe tomorrow).

- Nikita Skovoroda


On Feb. 28, 2014, 11:05 p.m., Nikita Skovoroda wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116067/
> -----------------------------------------------------------
> 
> (Updated Feb. 28, 2014, 11:05 p.m.)
> 
> 
> Review request for QML Web and Anton Kreuzkamp.
> 
> 
> Repository: qmlweb
> 
> 
> Description
> -------
> 
> Implement WebSocket type.
> 
> A simple wrapper around javascript WebSocket class ( http://caniuse.com/websockets ).
> 
> API compatible with Qt.WebSockets (see https://qt.gitorious.org/qt/websockets ).
> The Qt.WebSockets module will be included in Qt 5.3 release: http://qt-project.org/wiki/New-Features-in-Qt-5.3#a12a092a739cea3499350adb459d86b0 .
> 
> 
> Diffs
> -----
> 
>   src/qtcore.js eddc070 
> 
> Diff: https://git.reviewboard.kde.org/r/116067/diff/
> 
> 
> Testing
> -------
> 
> Works for me.
> 
> I could send and recieve messages and get status updates.
> 
> 
> Thanks,
> 
> Nikita Skovoroda
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/qmlweb/attachments/20140228/adf3eb9f/attachment.html>


More information about the QmlWeb mailing list