D20217: Remove kwallet4 support
Gleb Popov
noreply at phabricator.kde.org
Wed May 3 10:03:15 BST 2023
arrowd added inline comments.
INLINE COMMENTS
> pam_kwallet.c:436
>
> -#ifdef KWALLET5
> - char* extraArg = NULL;
> -#else
> - char* extraArg = "--nofork";
> -#endif
> - char *args[] = {strdup(kwalletd), "--pam-login", pipeInt, sockIn, extraArg, NULL};
> + char *args[] = {strdup(kwalletd), "--pam-login", pipeInt, sockIn, NULL, NULL};
> execve(args[0], args, pam_getenvlist(pamh));
I wonder why one of `NULL` wasn't removed completely?
REPOSITORY
R107 KWallet PAM Integration
REVISION DETAIL
https://phabricator.kde.org/D20217
To: davidedmundson, #plasma, apol
Cc: arrowd, plasma-devel, balaji, galderaa, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20230503/6d04120d/attachment.htm>
More information about the Plasma-devel
mailing list