<table><tr><td style="">arrowd added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D20217">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D20217#inline-175532">View Inline</a><span style="color: #4b4d51; font-weight: bold;">pam_kwallet.c:436</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span class="bright"></span><span style="color: #304a96"><span class="bright">#ifdef KWALLET5</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span style="color: #aa4000">char</span><span style="color: #aa2211">*</span> <span class="n">extraArg</span> <span style="color: #aa2211">=</span> <span style="color: #304a96">NULL</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span style="color: #304a96">#else</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span style="color: #aa4000">char</span><span style="color: #aa2211">*</span> <span class="n">extraArg</span> <span style="color: #aa2211">=</span> <span style="color: #766510">"--nofork"</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span style="color: #304a96">#endif</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span style="color: #aa4000">char</span> <span style="color: #aa2211">*</span><span class="n">args</span><span class="p">[]</span> <span style="color: #aa2211">=</span> <span class="p">{</span><span class="n">strdup</span><span class="p">(</span><span class="n">kwalletd</span><span class="p">),</span> <span style="color: #766510">"--pam-login"</span><span class="p">,</span> <span class="n">pipeInt</span><span class="p">,</span> <span class="n">sockIn</span><span class="p">,</span> <span class="n">extraArg</span><span class="p">,</span> <span style="color: #304a96">NULL</span><span class="p">};</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="bright">    </span><span style="color: #aa4000"><span class="bright">char</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">*</span></span><span class="bright"></span><span class="n"><span class="bright">args</span></span><span class="bright"></span><span class="p"><span class="bright">[]</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">=</span></span><span class="bright"> </span><span class="p"><span class="bright">{</span></span><span class="bright"></span><span class="n"><span class="bright">strdup</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">kwalletd</span></span><span class="bright"></span><span class="p"><span class="bright">),</span></span><span class="bright"> </span><span style="color: #766510"><span class="bright">"--pam-login"</span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"> </span><span class="n"><span class="bright">pipeInt</span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"> </span><span class="n"><span class="bright">sockIn</span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"> </span><span style="color: #304a96"><span class="bright">NULL</span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"> </span><span style="color: #304a96"><span class="bright">NULL</span></span><span class="bright"></span><span class="p"><span class="bright">};</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">execve</span><span class="p">(</span><span class="n">args</span><span class="p">[</span><span style="color: #601200">0</span><span class="p">],</span> <span class="n">args</span><span class="p">,</span> <span class="n">pam_getenvlist</span><span class="p">(</span><span class="n">pamh</span><span class="p">));</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I wonder why one of <tt style="background: #ebebeb; font-size: 13px;">NULL</tt> wasn't removed completely?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R107 KWallet PAM Integration</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D20217">https://phabricator.kde.org/D20217</a></div></div><br /><div><strong>To: </strong>davidedmundson, Plasma, apol<br /><strong>Cc: </strong>arrowd, plasma-devel, balaji, galderaa, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart<br /></div>