D29808: KSysGuard Network Plugin: Don't use std::regex to parse the network files.

Arjen Hiemstra noreply at phabricator.kde.org
Mon May 18 12:58:55 BST 2020


ahiemstra requested changes to this revision.
ahiemstra added a comment.
This revision now requires changes to proceed.


  Hmm, this is good idea, I'm not really happy about the implementation though. It's all C code whereas the rest of the helper is C++. It also relies very heavily on magic numbers now.
  
  I think a much simpler implementation would be to split each line on " ", select the fields we want and clean them up.

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D29808

To: dkorth, ahiemstra
Cc: ahiemstra, jpalecek, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200518/407a46d3/attachment.htm>


More information about the Plasma-devel mailing list