D29808: KSysGuard Network Plugin: Don't use std::regex to parse the network files.
David Korth
noreply at phabricator.kde.org
Sun May 17 18:15:37 BST 2020
dkorth created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
dkorth requested review of this revision.
REVISION SUMMARY
std::regex is slow, so use fixed-field parsing instead.
This is an initial version that I've been using for a while with no major issues, though it might still need some improvements. CPU usage is significantly decreased compared to before when there is a lot of network activity.
TEST PLAN
Run programs that generate a lot of network activity.
Verify the network activity shows up correctly with this patch.
REPOSITORY
R106 KSysguard
REVISION DETAIL
https://phabricator.kde.org/D29808
AFFECTED FILES
plugins/process/network/helper/Accumulator.cpp
plugins/process/network/helper/ConnectionMapping.cpp
plugins/process/network/helper/ConnectionMapping.h
To: dkorth
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200517/58f8592f/attachment.htm>
More information about the Plasma-devel
mailing list