D29709: Give all OverlaySheets consistent headers

Aleix Pol Gonzalez noreply at phabricator.kde.org
Wed May 13 14:38:09 BST 2020


apol added a comment.


  We are in string freeze right now, aren't we?

INLINE COMMENTS

> ApplicationPage.qml:282
>              enabled: appInfo.application.isInstalled
> -            visible: reviewsModel.backend && reviewsModel.backend.isResourceSupported(appInfo.application)
> +//             visible: reviewsModel.backend && reviewsModel.backend.isResourceSupported(appInfo.application)
>              Layout.topMargin: Kirigami.Units.largeSpacing

I guess this was for testing?

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D29709

To: ngraham, apol, #discover_software_store, #vdg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200513/95ed5094/attachment.htm>


More information about the Plasma-devel mailing list